fix: add Docker registry authentication for image push #9

Merged
twerner merged 1 commit from bugfix/docker-registry-auth into dev 2026-05-19 20:43:23 +00:00
Collaborator
No description provided.
fix: add Docker registry authentication for image push
All checks were successful
AI Code Review / ai-review (pull_request) Successful in 24s
CI / test (pull_request) Successful in 20s
CI / docker (pull_request) Successful in 17s
b01d545f1e

🤖 AI Code Review

Review Summary

I've analyzed the Git diff for this PR. Here's my assessment:


⚠️ Out of Scope

This diff modifies a CI/CD workflow file (.forgejo/workflows/ci.yaml), which falls under infrastructure adjustments per the review guidelines. These changes are not subject to standard code review.


Infrastructure Changes (Summary)

The PR adds Docker registry authentication for image pushes with the following logic:

  • Trigger condition: Only runs on non-PR events AND when the branch name does NOT start with feature/
  • Authentication: Uses docker/login-action@v3 with FORGEJO_TOKEN secret
  • Image tagging: Pushes to forgejo.to-wer.de/twerner/coder-bot/telegram-bridge:latest

💡 Observations

Positive aspects:

  • Proper use of conditional execution to avoid authenticating on PRs or feature branches
  • Secret management via secrets.FORGEJO_TOKEN rather than hardcoded credentials
  • Uses official docker/login-action rather than manual docker login commands

Minor note:

  • The final line change (adding a newline) is good practice for file formatting

📝 Recommendation

Since this is an infrastructure change, please ensure:

  1. The FORGEJO_TOKEN secret is properly configured in your Forgejo/GitHub secrets settings
  2. The token has appropriate write permissions to the target registry
  3. Consider adding a timeout or retry mechanism for the login step in production environments

No code-level issues detected. The implementation follows CI/CD best practices for container registry authentication.


Generated by [poolside/laguna-xs.2:free] via AI Code Review Action

## 🤖 AI Code Review ## Review Summary I've analyzed the Git diff for this PR. Here's my assessment: --- ## ⚠️ Out of Scope **This diff modifies a CI/CD workflow file (`.forgejo/workflows/ci.yaml`), which falls under infrastructure adjustments per the review guidelines. These changes are not subject to standard code review.** --- ## ✅ Infrastructure Changes (Summary) The PR adds Docker registry authentication for image pushes with the following logic: - **Trigger condition**: Only runs on non-PR events AND when the branch name does NOT start with `feature/` - **Authentication**: Uses `docker/login-action@v3` with `FORGEJO_TOKEN` secret - **Image tagging**: Pushes to `forgejo.to-wer.de/twerner/coder-bot/telegram-bridge:latest` --- ## 💡 Observations **Positive aspects:** - Proper use of conditional execution to avoid authenticating on PRs or feature branches - Secret management via `secrets.FORGEJO_TOKEN` rather than hardcoded credentials - Uses official `docker/login-action` rather than manual `docker login` commands **Minor note:** - The final line change (adding a newline) is good practice for file formatting --- ## 📝 Recommendation Since this is an infrastructure change, please ensure: 1. The `FORGEJO_TOKEN` secret is properly configured in your Forgejo/GitHub secrets settings 2. The token has appropriate write permissions to the target registry 3. Consider adding a timeout or retry mechanism for the login step in production environments **No code-level issues detected.** The implementation follows CI/CD best practices for container registry authentication. --- *Generated by [poolside/laguna-xs.2:free] via AI Code Review Action*
twerner deleted branch bugfix/docker-registry-auth 2026-05-19 20:43:24 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
twerner/coder-bot!9
No description provided.